feat: driving dimensions #1340
Open
feat: driving dimensions #1340
+376
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
- Coverage 91.84% 91.68% -0.16%
==========================================
Files 86 88 +2
Lines 6928 6988 +60
==========================================
+ Hits 6363 6407 +44
- Misses 565 581 +16 ☔ View full report in Codecov by Sentry. |
|
Let's discuss this later @umutsoysalansys but I wouldn't have it as an independent module of the whole "design" structure. I think driving dimensions should be a property of bodies... |
RobPasMue
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Overall looks good @umutsoysalansys! I left some enhancement suggestions. Main missing point is an example. We need examples that demonstrates how to use these new features. This is part of the requested actions for any new implementation. Otherwise users won't know how to make use of it.
tests/integration/test_design.py
Outdated
Comment on lines
2675
to
2677
| def test_design_parameters(modeler: Modeler): | ||
| """Test the design parameters functionality.""" | ||
|
|
There was a problem hiding this comment.
Seems like the test is failing - do you know the reason? There seems to be some kind of issue with the server apparently... We are using the latest proto and servers to check this so... maybe a pending PR on the server side?
RobPasMue
requested changes
Oct 16, 2024
PipKat
reviewed
Oct 23, 2024
PipKat
reviewed
Oct 23, 2024
PipKat
reviewed
Oct 23, 2024
PipKat
reviewed
Oct 23, 2024
PipKat
reviewed
Oct 23, 2024
PipKat
reviewed
Oct 23, 2024
PipKat
reviewed
Oct 23, 2024
PipKat
previously approved these changes
Oct 23, 2024
|
Style guidelines say to use "you" rather than "we" as you are addressing the reader.
________________________________
From: Umut Soysal ***@***.***>
Sent: Wednesday, October 23, 2024 1:12 PM
To: ansys/pyansys-geometry ***@***.***>
Cc: Kathy Pippert ***@***.***>; Mention ***@***.***>
Subject: Re: [ansys/pyansys-geometry] feat: driving dimensions (PR #1340)
[External Sender]
@umutsoysalansys commented on this pull request.
________________________________
In doc/source/examples/03_modeling/design_parameters.mystnb<#1340 (comment)>:
+jupytext:
+ text_representation:
+ extension: .mystnb
+ format_name: myst
+ format_version: 0.13
+ jupytext_version: 1.16.4
+kernelspec:
+ display_name: Python 3 (ipykernel)
+ language: python
+ name: python3
+---
+
+# Modeling: Using Design Parameters
+
+You can read and update parameters that are part of the design.
+In this example, we have a simple design with two associated parameters.
Thanks for the reviews @PipKat<https://github.com/PipKat>, I used "we" based on the previous examples on this examples section, so maybe they need to be corrected as well? thanks
https://github.com/ansys/pyansys-geometry/blob/150c19b9dabe92e999262f89233970efc5c6c96a/doc/source/examples/01_getting_started/05_plotter_picker.mystnb#L177C23-L177C30
—
Reply to this email directly, view it on GitHub<#1340 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUHQY26UBZQP3CF4TVJKWEDZ47KIDAVCNFSM6AAAAABL46RXW6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBZGQ4DKNJXGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
auto-merge was automatically disabled
November 13, 2024 14:37
Pull request was converted to draft
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bringing driving dimensions/ geometry parametrization to pyansys-geometry.
Issue linked
Checklist
feat: extrude circle to cylinder)